Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1166
User - Manager runs local worker on thread - Gen Worker 0
The manager can start an additional worker thread with the worker ID 0.
This worker is, via
W["gen_worker"] = True, and filtering options, made to run gens only.Tentative interface:
libE_specs["gen_on_manager"] = TrueInternal - Refactor runners.py
Largely refactors utils/runners.py so additional "Runners" for user functions can be more easily developed/extended.
GlobusComputeRunner and ThreadRunner inherit from Runner.
Runner inspects the contents of the input sim/gen specs and instantiates the correct subclass on the left-hand-side:
Internal - _WorkerIndexer class for indexing into worker arrays
Internal - Workers can be assigned gen_worker.